Less allocations, coordinates, and a corner case #2078
Conversation
|
Please merge. Needed for oscar-system/Oscar.jl#5545 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2078 +/- ##
==========================================
+ Coverage 76.97% 77.05% +0.07%
==========================================
Files 370 370
Lines 118430 118476 +46
==========================================
+ Hits 91159 91287 +128
+ Misses 27271 27189 -82
🚀 New features to boost your workflow:
|
|
If you bump the version to bla.bla.1 in this PR, we can do a release after this is merged. |
|
Will do and maybe move a bit more code from the other PR. So that we need only a single release. |
src/QuadForm/Morphism.jl
Outdated
| continue | ||
| else | ||
| return x[i] < y[i] | ||
| return cmp(xi,yi)<0 |
There was a problem hiding this comment.
wanna have fun? c = cmp(xi, yi); c == 0 && continue; return c; then the comparison is only done once...
There was a problem hiding this comment.
Right, thanks!
| end | ||
| xi = mat_entry_ptr(x, 1, i) | ||
| yi = mat_entry_ptr(y, 1, i) | ||
| c = cmp(xi,yi) |
There was a problem hiding this comment.
too fast: c is also used for the ncols. This is definitely a speed up!
|
Ready to go from my side. |
No description provided.