Emulating initalState function for Hooks#77
Open
jterbraak wants to merge 4 commits intothomashoneyman:mainfrom
Open
Emulating initalState function for Hooks#77jterbraak wants to merge 4 commits intothomashoneyman:mainfrom
jterbraak wants to merge 4 commits intothomashoneyman:mainfrom
Conversation
added 2 commits
September 26, 2022 17:20
Halogen does not seem to guarantee the order of HalogenQ. It's possible that Receive or Query arrive before Initialize fires. This means that the HookState has to be ready before evalHook ever fires. mkInitialState contains most of the old Initialize step code.
Owner
|
Hi @jterbraak! Thanks for opening this PR. I'm on vacation until October 9, and I can take a thorough look at this then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out my previous fix only papers over the real issue in #73.
Halogen does not seem to guarantee the order in which HalogenQ fires. It's possible that Receive or Query arrive before Initialize. This means that the HookState has to be ready before evalHook is ever called. mkInitialState contains most of the old Initialize step code.
This PR adds the mkInitialState function which is an analog to initialState in vanilla Halogen. Given a Hook and the input it constructs the HookState required for evalHook.
Unfortunately this is a big change and I had to touch every test. It also slightly changes the behavior: