Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 31, 2025

Demo video recording fails silently when locators timeout or elements aren't clickable, making test failures difficult to debug without visual artifacts.

Changes

Workflow (.github/workflows/tests.yml)

  • Mark video generation step as continue-on-error: true with step ID to capture outcome
  • Add if: always() to post-processing, uploads, summary, and PR comment steps
  • Check file existence before S3 upload to handle partial failures
  • Pass test outcome to markdown generator via TEST_STATUS environment variable

Markdown Generator (scripts/generateMarkdownSummary.js)

  • Accept optional test status parameter (defaults to success for backward compatibility)
  • Show ⚠️ icon and warning note when status is not success
  • Handle missing scenes.json gracefully instead of crashing

Behavior

Before: Test fails → no video uploaded → no debugging artifacts

After: Test fails → partial video uploaded → PR comment shows:

## ⚠️ Demo Video Generated (Test Failed)

> ⚠️ **Note**: The demo test encountered errors but videos were still uploaded for debugging. Check the logs for details.

### Full Video
[📥 Download Full Video (MP4)] | [GIF]

Matches existing demo-video-mobile job behavior.

Original prompt

update the demo video workflow so the video is also uploaded if there was an error during the recording (eg. A locator failed or a fun element could not be clicked)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits December 31, 2025 20:36
- Add continue-on-error: true to video generation step
- Add if: always() to post-processing and upload steps
- Add file existence checks before uploading
- Update generateMarkdownSummary.js to support test status parameter
- Display warning when test fails but videos are uploaded

Co-authored-by: thomasnordquist <[email protected]>
- Add comment explaining TEST_STATUS outcome values
- Improve error message specificity in generateMarkdownSummary.js

Co-authored-by: thomasnordquist <[email protected]>
Copilot AI changed the title [WIP] Update demo video workflow to upload on errors Upload demo videos even when UI tests fail Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants