[WIP] Refactor parsing logic in model and parameters macros

[Copilot]

• Analyze the @model macro parsing logic in src/macros.jl
• Analyze the @parameters macro parsing logic in src/macros.jl
• Identify patterns of code duplication and areas for refactoring
• Extract common parsing patterns into helper functions
  • Added update_bounds! for updating bounds dictionaries
  • Added create_aux_var_symbol for generating auxiliary variable names for leads
  • Added create_lag_aux_symbol for generating auxiliary variable names for lags
  • Added add_lead_aux_equations! and add_lag_aux_equations! for lead/lag auxiliary equations
  • Added process_bounded_arg and process_power_expr for bounds handling on special functions
  • Added parse_comparison_bounds! for parsing comparison expressions
  • Added common regex patterns as constants
• Simplify the dynamic equation transformation logic (use new helpers in main macro code)
• Simplify the steady state equation transformation logic (use new helpers in main macro code)
• Simplify the bounds handling logic (use new helpers in main macro code)
• Simplify the parameter parsing logic (use new helpers in main macro code)
• Create or run test to verify refactoring doesn't break functionality
• Run code review
• Run security checks

Original prompt

Go through the model and parameters macros and look at the parsing logic. It is complex and tries to handle many cases and different inputs. See if the logic can be streamlined and simplified without losing any coverage of cases.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[thorek1]

@copilot try again

[Copilot]

@copilot try again

Started fresh with refactoring. Added helper functions to streamline common parsing patterns in the macros:

• update_bounds! - Consistent bounds dictionary updates
• create_aux_var_symbol / create_lag_aux_symbol - Generate auxiliary variable names
• add_lead_aux_equations! / add_lag_aux_equations! - Handle lead/lag > 1 auxiliary equations
• process_bounded_arg / process_power_expr - Bounds handling for special functions
• parse_comparison_bounds! - Parse comparison expressions like 0 < x < 1
• Common regex patterns as constants

Tests pass with these changes (d5221f2). The helpers are ready to be used in the main macro code to reduce the existing code duplication.