Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prescriptions metadata in handlers #155

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Add prescriptions metadata in handlers #155

merged 1 commit into from
Aug 5, 2022

Conversation

mayaCostantini
Copy link
Contributor

@mayaCostantini mayaCostantini commented May 5, 2022 •
edited
Loading

Related Issues and Dependencies

Related to thoth-station/adviser#2180

  • make sure prescriptions-refresh-job creates prescriptions with additional tags/categories in metadata

This introduces a breaking change

  • No

This should yield a new module release

  • Yes

This Pull Request implements

Compute prescriptions metadata in handlers:

  • prescriptions repository
  • prescriptions version
  • last CVE database update for cve_warning handler

This list could eventually be expanded depending on the outcome of thoth-station/adviser#2328

@mayaCostantini
Copy link
Contributor Author

/hold

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2022
@mayaCostantini mayaCostantini changed the title Add prescriptions metadata in handlers WIP Add prescriptions metadata in handlers May 5, 2022
@sesheta sesheta added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 5, 2022
@sesheta
Copy link
Member

sesheta commented Aug 3, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2022
@mayaCostantini mayaCostantini removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2022
@mayaCostantini mayaCostantini changed the title WIP Add prescriptions metadata in handlers Add prescriptions metadata in handlers Aug 4, 2022
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2022
@mayaCostantini
Copy link
Contributor Author

Rebased to solve merge conflict. Ready for review.

@mayaCostantini mayaCostantini requested review from harshad16 and removed request for pacospace August 4, 2022 16:56
@mayaCostantini mayaCostantini mentioned this pull request Aug 4, 2022
Open
1 task
harshad16
harshad16 approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks 👍

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2022
@sesheta
Copy link
Member

sesheta commented Aug 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
@mayaCostantini
Copy link
Contributor Author

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2022
@sesheta sesheta merged commit 642074d into thoth-station:master Aug 5, 2022
@mayaCostantini mayaCostantini deleted the generate-metadata branch August 5, 2022 18:32
@harshad16 harshad16 mentioned this pull request Sep 13, 2022
Closed
@codificat codificat mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees

@harshad16 harshad16

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayaCostantini @sesheta @harshad16