Use a single struct for TalismanRC #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files outside of talismanrc are using the underlying type to manage ignoring specific files, so it isn't sufficiently abstracting the capabilty. This brings persistedRC and TalismanRC closer together. Authored-by: Owen Nelson <[email protected]>
Authored-by: Owen Nelson <[email protected]>
Authored-by: Owen Nelson <[email protected]>
Authored-by: Owen Nelson <[email protected]>
Authored-by: Owen Nelson <[email protected]>
Authored-by: Owen Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #471, we no longer need complex logic when generating a TalismanRC struct from a .talismanrc file. This simplifies loading from and writing to a .talismanrc file by directly unmarshalling/marshalling TalismanRC, instead of using the persistedRC struct as an intermediate.