Skip to content

Chore: Build the docs when benchmarks/results/** change #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

codeallthethingz
Copy link
Contributor

@codeallthethingz codeallthethingz commented Feb 13, 2025

This PR fixes a problem where the docs are not getting rebuilt by the the preview system when the benchmarks/results change as they were not included in the build path trigger.

@codeallthethingz codeallthethingz added the triaged This issue or pull request was triaged label Feb 13, 2025
@codeallthethingz codeallthethingz changed the title Chore: Build the docs when benchmarks/results/** changes Chore: Build the docs when benchmarks/results/** change Feb 13, 2025
@codeallthethingz codeallthethingz marked this pull request as ready for review February 13, 2025 17:52
Copy link
Contributor

@tristanls tristanls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tristanls tristanls added the infrastructure Changes to infrastructure label Feb 13, 2025
@codeallthethingz codeallthethingz merged commit 084446e into thousandbrainsproject:main Feb 13, 2025
14 checks passed
@codeallthethingz codeallthethingz deleted the build-preview-docs-on-results-change branch February 13, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes to infrastructure triaged This issue or pull request was triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants