docs: additional context for evidence_update_threshold #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristanls
added
documentation
vkakerbeck
reviewed
Feb 25, 2025
There was a problem hiding this comment.
Thanks for adding the clarification! Just one note: Only the '[int]%' and 'x_percent_threshold' options look at the evidence of the MLH. The other options would set a fixed threshold that doesn't take the evidence of the MLH into account. (or a varying threshold in the case of 'mean' and 'median' which take all evidences for all hypotheses into account)
tristanls
force-pushed
the
evidence_docstring
branch
from
588fcd4 to
88f9eae
Compare
|
Thank you @vkakerbeck, updated. |
vkakerbeck
approved these changes
Feb 26, 2025
Comment on lines
179
to
185
| When this parameter is either '[int]%' or 'x_percent_threshold`, then | ||
| this parameter is applied to the Most Likely Hypothesis (MLH) to | ||
| determine a minimum evidence threshold in order for other hypotheses to be | ||
| updated. Any hypotheses falling below the resulting evidence threshold do | ||
| not get updated. The other options set a fixed threshold that does not | ||
| take MLH into account.In [int, float, '[int]%', 'mean', 'median', 'all', | ||
| 'x_percent_threshold']. |
There was a problem hiding this comment.
Suggested change
| When this parameter is either '[int]%' or 'x_percent_threshold`, then | |
| this parameter is applied to the Most Likely Hypothesis (MLH) to | |
| determine a minimum evidence threshold in order for other hypotheses to be | |
| updated. Any hypotheses falling below the resulting evidence threshold do | |
| not get updated. The other options set a fixed threshold that does not | |
| take MLH into account.In [int, float, '[int]%', 'mean', 'median', 'all', | |
| 'x_percent_threshold']. | |
| When this parameter is either '[int]%' or 'x_percent_threshold`, then | |
| this parameter is applied to the evidence for the Most Likely Hypothesis (MLH) | |
| to determine a minimum evidence threshold in order for other hypotheses to be | |
| updated. Any hypotheses falling below the resulting evidence threshold do | |
| not get updated. The other options set a fixed threshold that does not | |
| take MLH evidence into account. In [int, float, '[int]%', 'mean', 'median', 'all', | |
| 'x_percent_threshold']. |
There was a problem hiding this comment.
Thank you, I added this as well 👍.
tristanls
force-pushed
the
evidence_docstring
branch
from
858b9c1 to
6f9b522
Compare
nielsleadholm
pushed a commit
to nielsleadholm/tbp.monty
that referenced
this pull request
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vkakerbeck gave this explanation for
evidence_update_thresholdin a video. This explanation is what clicked for me and apparently @scottcanoe. This pull request adds it for context for others who try to understand the purpose of this parameter.