Skip to content

build: use version from source; remove obsolete option #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2025
Merged

build: use version from source; remove obsolete option #189

merged 2 commits into from
Feb 25, 2025

Conversation

tristanls
Copy link
Contributor

@tristanls tristanls commented Feb 25, 2025 •
edited
Loading

With RFC Monty Versioning almost merged, this pull request ensures that the version used in the build comes from the __version__ variable.

Obsolete bdst_wheel option is removed.

Python version is set to >=3.8 to correspond to conda's python=3.8 requirement.

@tristanls tristanls added infrastructure Changes to infrastructure triaged This issue or pull request was triaged labels Feb 25, 2025
vkakerbeck
vkakerbeck approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@vkakerbeck vkakerbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

codeallthethingz
codeallthethingz approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@codeallthethingz codeallthethingz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tristanls tristanls merged commit 92cb665 into thousandbrainsproject:main Feb 25, 2025
13 checks passed
@tristanls tristanls deleted the build branch February 25, 2025 21:14
nielsleadholm pushed a commit to nielsleadholm/tbp.monty that referenced this pull request Mar 3, 2025
@tristanls @nielsleadholm
build: use version from source; remove obsolete option (thousandbrain…
7b5662a 
…sproject#189)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeallthethingz codeallthethingz codeallthethingz approved these changes

@vkakerbeck vkakerbeck vkakerbeck approved these changes

Assignees

@codeallthethingz codeallthethingz

@vkakerbeck vkakerbeck

Labels
infrastructure Changes to infrastructure triaged This issue or pull request was triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tristanls @codeallthethingz @vkakerbeck