Skip to content

build: reset version to 0.0.0 to satisfy conda constraint #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

tristanls
Copy link
Contributor

@tristanls tristanls commented Feb 25, 2025

When testing building Monty for conda distribution, observed that conda does not allow - in the version name.

(tbp.monty) me@only_slightly_bent tbp.monty % conda build .
(...)

CondaBuildUserError: Bad character(s) (-) in package/version: 0.0.1-dev0.

This pull request resets the version to 0.0.0 to satisfy this conda constraint. According to RFC 7 Monty Versioning, we also do not anticipate using build versions at this time.

@tristanls tristanls added infrastructure Changes to infrastructure triaged This issue or pull request was triaged labels Feb 25, 2025
Copy link
Contributor

@codeallthethingz codeallthethingz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vkakerbeck vkakerbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tristanls tristanls merged commit 0ebedd0 into thousandbrainsproject:main Feb 26, 2025
13 checks passed
@tristanls tristanls deleted the version_reset branch February 26, 2025 08:51
nielsleadholm pushed a commit to nielsleadholm/tbp.monty that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes to infrastructure triaged This issue or pull request was triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants