thcrap_cs_lib: Moved all the necessary code from configure_v3 #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brliron
reviewed
May 13, 2025
There was a problem hiding this comment.
Just 2 comments about style (and because style is subjective, I'm open to talk about it if you think your version is objectively better).
I also think a few more things could be moved from thcrap_configure_v3 to thcrap_cs_lib, but these can easily be moved later, when we need to use them in more than one project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's all I've done, at most declaring some classes as public too.
I've made configure_v3 work with the new Class Library, and I made it a dependency.