Cyberstorm api create/delete service account (TS-2320) #1098
+336
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
django/thunderstore/api/cyberstorm/tests/test_create_service_account.py
Outdated
Show resolved
Hide resolved
django/thunderstore/api/cyberstorm/tests/test_create_service_account.py
Outdated
Show resolved
Hide resolved
Roffenlund
force-pushed
the
cyberstorm-api-create-service-account
branch
from
f59e764 to
7580d68
Compare
Roffenlund
changed the title
Roffenlund
changed the title
x753
reviewed
Feb 17, 2025
x753
reviewed
Feb 17, 2025
x753
reviewed
Feb 18, 2025
Roffenlund
force-pushed
the
cyberstorm-api-create-service-account
branch
from
9e7246d to
d1f1098
Compare
Implement a serializer for creating service accounts, and a serializer for deleting service accounts. Two of the fields in the serializer intended for creating service accounts are read-only, as they are only required in the response from the view. Refs. TS-2320
Added CreateServiceAccountAPIView and DeleteServiceAccountAPIView to manage service account creation and deletion with team-specific permission checks. Introduced TeamPermissionMixin to handle permission checks for users based on team access and actions on service accounts. Both views enforce team-based access control, ensuring users have the appropriate permissions to create or delete service accounts for the given team. Refs. TS-2320
Refs. TS-2320
Rename team_id to team_name in the kwargs for the create/delete service account endpoints. Refs. TS-2320
- Inherit DestroyAPIView in DeleteServiceAccountAPIView. - Use delete() instead of post() for deleting service accounts. - Add uuid to URL instead of sending a payload to the DELETE endpoint. - Update tests accordingly. Refs. TS-2320
Roffenlund
force-pushed
the
cyberstorm-api-create-service-account
branch
from
d1f1098 to
a5fa14c
Compare
Add missing parameter whe calling the ServiceAccount's .create function. Error raised after rebase. Refs. TS-2320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the following:
CreateServiceAccountAPIView: Handles the creation of service accounts with team-specific permission checks, ensuring that only authorized users can create service accounts for a given team.
DeleteServiceAccountAPIView: Manages the deletion of service accounts, enforcing team-based permissions to ensure that only users with the right access can delete service accounts for a team.
TeamPermissionMixin: A mixin class that centralizes the logic for permission checks based on team access. It ensures that users are authorized to perform actions on service accounts for the specified team.