fix: enhance cropByBBox() input validation to prevent panics
#391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Validate `padding`: reject NaN, Infinity, and negative values (use 0.0 for invalid) - Validate bbox: dimensions must be positive (non-positive silently ignored) - Change threshold from == 0.0 to < 1.0 to prevent OOM risk - Replace all .unwrap() calls with if let Some() for safe error handling - Add edge case tests for invalid inputs
yisibl
force-pushed
the
fix-cropByBBox-limit
branch
from
c398196 to
b8a161e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
padding: reject NaN, Infinity, and negative values (use 0.0 for invalid)