This repository was archived by the owner on Jan 5, 2025. It is now read-only.
changed <svg> tag regexes #20
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve issue #19, these regex changes (based on https://github.com/tiagoporto/jquery-svg-to-inline/issues/19#issuecomment-407540570 ) allow for inlining SVG files with
<svg>
tag —<svg id="Layer_1"
<svg>
tag —<svg style="enable-background:new 0 0 512 512;"
<svg>
The regexes are now less restrictive, so they should cover any situation. The
<svg>
one says "match<svg
, then match anything that isn't a>
character, then match a>
character." While I was at it, I changed the regexes that find HTML comments, the<?xml
tag, and theclass
attribute in the same manner.This is the SVG I used for testing (I had to change its extension to
.txt
so I could attach it to this pull request, so change it back to.svg
before using it):calculator.txt