Skip to content

Support multi module system implementation #179

Support multi module system implementation

Support multi module system implementation #179

Triggered via pull request January 1, 2024 03:58
Status Failure
Total duration 1m 3s
Artifacts

clippy.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 12 warnings
clippy
Process completed with exit code 101.
rustfmt check: /home/runner/work/KernelSU/KernelSU/userspace/ksud/src/module_api.rs#L116
Original: ``` fn mount_modules(&self) -> Result<()>{ Err(Command::new("/data/adb/ksu/module").args(["mount"]).exec().into()) ``` Expected: ``` fn mount_modules(&self) -> Result<()> { Err(Command::new("/data/adb/ksu/module") .args(["mount"]) .exec() .into()) ```
rustfmt check: /home/runner/work/KernelSU/KernelSU/userspace/ksud/src/module_api.rs#L113
Original: ``` fn list_modules(&self) -> Result<()>{ Err(Command::new("/data/adb/ksu/module").args(["list"]).exec().into()) ``` Expected: ``` fn list_modules(&self) -> Result<()> { Err(Command::new("/data/adb/ksu/module") .args(["list"]) .exec() .into()) ```
rustfmt check: /home/runner/work/KernelSU/KernelSU/userspace/ksud/src/module_api.rs#L110
Original: ``` fn disable_module(&self, id: &str) -> Result<()>{ Err(Command::new("/data/adb/ksu/module").args(["disable", id]).exec().into()) ``` Expected: ``` fn disable_module(&self, id: &str) -> Result<()> { Err(Command::new("/data/adb/ksu/module") .args(["disable", id]) .exec() .into()) ```
rustfmt check: /home/runner/work/KernelSU/KernelSU/userspace/ksud/src/module_api.rs#L107
Original: ``` fn enable_module(&self, id: &str) -> Result<()>{ Err(Command::new("/data/adb/ksu/module").args(["enable", id]).exec().into()) ``` Expected: ``` fn enable_module(&self, id: &str) -> Result<()> { Err(Command::new("/data/adb/ksu/module") .args(["enable", id]) .exec() .into()) ```
rustfmt check: /home/runner/work/KernelSU/KernelSU/userspace/ksud/src/module_api.rs#L104
Original: ``` fn uninstall_module(&self, id: &str) -> Result<()>{ Err(Command::new("/data/adb/ksu/module").args(["uninstall", id]).exec().into()) ``` Expected: ``` fn uninstall_module(&self, id: &str) -> Result<()> { Err(Command::new("/data/adb/ksu/module") .args(["uninstall", id]) .exec() .into()) ```
rustfmt check: /home/runner/work/KernelSU/KernelSU/userspace/ksud/src/module_api.rs#L101
Original: ``` fn install_module(&self, zip: &str) -> Result<()>{ Err(Command::new("/data/adb/ksu/module").args(["install", zip]).exec().into()) ``` Expected: ``` fn install_module(&self, zip: &str) -> Result<()> { Err(Command::new("/data/adb/ksu/module") .args(["install", zip]) .exec() .into()) ```
rustfmt check: /home/runner/work/KernelSU/KernelSU/userspace/ksud/src/module_api.rs#L98
Original: ``` fn on_services(&self) -> Result<()>{ Err(Command::new("/data/adb/ksu/module").args("services").exec().into()) ``` Expected: ``` fn on_services(&self) -> Result<()> { Err(Command::new("/data/adb/ksu/module") .args("services") .exec() .into()) ```
rustfmt check: /home/runner/work/KernelSU/KernelSU/userspace/ksud/src/module_api.rs#L95
Original: ``` fn on_boot_completed(&self) -> Result<()>{ Err(Command::new("/data/adb/ksu/module").args("boot-completed").exec().into()) ``` Expected: ``` fn on_boot_completed(&self) -> Result<()> { Err(Command::new("/data/adb/ksu/module") .args("boot-completed") .exec() .into()) ```
rustfmt check: /home/runner/work/KernelSU/KernelSU/userspace/ksud/src/module_api.rs#L91
Original: ``` impl ModuleApi for ExternalModuleApi{ fn on_post_data_fs(&self) -> Result<()>{ Err(Command::new("/data/adb/ksu/module").args("post-fs-data").exec().into()) ``` Expected: ``` impl ModuleApi for ExternalModuleApi { fn on_post_data_fs(&self) -> Result<()> { Err(Command::new("/data/adb/ksu/module") .args("post-fs-data") .exec() .into()) ```
rustfmt check: /home/runner/work/KernelSU/KernelSU/userspace/ksud/src/module_api.rs#L21
Original: ``` fn should_use_external_module_api() -> bool{ ``` Expected: ``` fn should_use_external_module_api() -> bool { ```
rustfmt check: /home/runner/work/KernelSU/KernelSU/userspace/ksud/src/module_api.rs#L4
Original: ``` use std::{process::Command, os::unix::process::CommandExt}; ``` Expected: ``` use std::{os::unix::process::CommandExt, process::Command}; ```