Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): make tabBarVisible work at creation #13872

Merged
merged 5 commits into from
Aug 19, 2023
Merged

fix(android): make tabBarVisible work at creation #13872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
259cd0f
fix(android): make tabBarVisible work at creation
m1ga Jun 27, 2023
5d13504
comment
m1ga Aug 19, 2023
30cd6f2
Update android/modules/ui/src/java/ti/modules/titanium/ui/widget/tabg…
m1ga Aug 19, 2023
49e6a30
Merge branch 'master' into 2306237_android_tabBarVisible
m1ga Aug 19, 2023
ebd540c
Merge branch 'master' into 2306237_android_tabBarVisible
m1ga Aug 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...ules/ui/src/java/ti/modules/titanium/ui/widget/tabgroup/TiUIBottomNavigationTabGroup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,14 @@ public void onLayoutChange(

// Set the ViewPager as a native view.
setNativeView(this.tabGroupViewPager);
if (!TiConvert.toBoolean(this.proxy.getProperty(TiC.PROPERTY_TAB_BAR_VISIBLE), true)) {
TiCompositeLayout.LayoutParams params = new TiCompositeLayout.LayoutParams();
params.autoFillsWidth = true;
params.optionBottom = new TiDimension(0, TiDimension.TYPE_BOTTOM);
this.tabGroupViewPager.setLayoutParams(params);
// FIXME change "500" to a calculate value https://github.com/tidev/titanium-sdk/issues/13900
this.mBottomNavigationView.setTranslationY(500);
}
}

/**
Expand Down
1 change: 1 addition & 0 deletions android/titanium/src/java/org/appcelerator/titanium/TiC.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,6 +751,7 @@ public class TiC
public static final String PROPERTY_SUPPORT_TOOLBAR = "supportToolbar";
public static final String PROPERTY_TABS = "tabs";
public static final String PROPERTY_TAB_OPEN = "tabOpen";
public static final String PROPERTY_TAB_BAR_VISIBLE = "tabBarVisible";
public static final String PROPERTY_TABS_BACKGROUND_COLOR = "tabsBackgroundColor";
public static final String PROPERTY_TABS_BACKGROUND_SELECTED_COLOR = "tabsBackgroundSelectedColor";
public static final String PROPERTY_TAB_MODE = "tabMode";
Expand Down
Loading