chore(android): gradle 8 #14014

AbdullahFaqeir · 2024-03-23T19:03:37Z

chore(android): let there be gradle 8
chore(android): fixed deprecations in kroll-apt project
chore(android): made kroll-apt incremental to enhance build time

GitHub issue: #13579

This PR is dedicated to my mentor Nafe Abboushi.

chore(android): fixed deprecations in kroll-apt project chore(android): made kroll-apt incremental to enhance build time

m1ga

Are the changes to the JAVA files necessary for the update? The more stuff that is changed, the more we have to test 😉

Also I wouldn't update the min and targetSDK with this PR. If we still can use 21 we should do that too. Same with target 34. I have a PR for that here #13940 as the broadcast receiver has to be adjusted.

So if that is not needed for the gradle PR please keep it as it is and do it in a separate PR (less changes, less testing).

I couldn't build a SDK locally. It's almost working but the last step titaniumPublication(MavenPublication) tries to publish it online instead of making a local repo? I've canceled it as it was uploading stuff 😄 Didn't want to publish something I don't need.

There aren't all cmake version available during build process. I have a different PR about that #13966 and I had to use 3.22.1 as that is available on all platforms.

fix(android): gradle 8 compatibility update to template build.gradle fix(android): revert dependency updates fix(android): revert minSdk and targetSdk

AbdullahFaqeir

All reviews applied.

fix(android): update _build.js & _buildModule.js for new gradle

m1ga · 2024-03-26T18:09:37Z

I have to do some testing but the first round was very good and I was able to build kitchensink an my app now 👍

Review will follow once I have more time to test

cb1kenobi

This is AWESOME! I don't wanna lose momentum on this PR.

I found a few indention nitpicks. I haven't tested the PR yet, but I spent some time researching some of the changes such as no longer need to call .setPackageName(). Good stuff!

What sort of testing do we need to do to get this over the finish line? I can test on Windows doing emulator builds as well as build-only device/dist builds. I don't have any working Android devices. Sigh.

android/build.gradle

android/app/build.gradle

android/templates/build/ti.constants.gradle

android/titanium/build.gradle

android/untar.gradle

m1ga · 2024-05-01T08:27:40Z

What sort of testing do we need to do to get this over the finish line?

👍 @cb1kenobi I would love to split this up into smaller steps as this is a big PR:
#13579 (comment)
I have made older PRs: first one only updates the gradle files to the newer syntax, 2nd one updates cmake and checkstyle (looks much but it's only linting). Then we only have the gradle 8 parts in here and can focus on that as it's a bigger change.

Co-authored-by: Chris Barber <[email protected]>

hansemannn

A few questions and changes we should verify. And can you please rebase with latest master to resolve the merge conflicts?

android/app/build.gradle

android/build.gradle

android/cli/commands/_buildModule.js

android/gradle/wrapper/gradle-wrapper.properties

android/templates/build/root.build.gradle

Co-authored-by: Chris Barber <[email protected]>

AbdullahFaqeir · 2024-09-13T00:41:03Z

@m1ga
Was this put in the system in any way or not, I hope so, and if not I would love to get back and work on it

AbdullahFaqeir · 2024-09-13T02:41:00Z

A few questions and changes we should verify. And can you please rebase with latest master to resolve the merge conflicts?

Of course

android/app/build.gradle

m1ga · 2024-09-13T14:34:57Z

Did a first quick test.

EDIT: I've pushed the material.R changes! SDK will build now 👍

After that: SDK builds fine and I tested it with two apps with existing modules and they work fine. Kitchensink works too. Hyperloop-examples breaks:

[ERROR] [GRADLE] A problem occurred configuring project ':gradle-project'.
[ERROR] [GRADLE] > Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
[ERROR] [GRADLE]    > Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.
[ERROR] [GRADLE]      
[ERROR] [GRADLE]      If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.
[ERROR] [GRADLE]

same when building modules:

[ERROR] [GRADLE] A problem occurred configuring project ':module'.
[ERROR] [GRADLE] > Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
[ERROR] [GRADLE]    > Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.
[ERROR] [GRADLE]      
[ERROR] [GRADLE]      If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.
[ERROR] [GRADLE]

android/gradle.properties

hansemannn · 2024-09-13T14:44:08Z

@m1ga PR's can be checked out most easily with the Github CLI and gh pr checkout 14014 in this case. It clones the branch and checks it out. You can then push into the branch and the commits occur here.

m1ga · 2024-09-13T14:54:00Z

@hansemannn nice! That worked 👍 SDK will build now, modules & hyperloop currently fail with the error above.

@AbdullahFaqeir would be nice if you can find out where the namespace is missing. Apps without hyperloop work fine but I didn't check all controls yet.

android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIButton.java

AbdullahFaqeir · 2024-09-13T20:13:13Z

@m1ga @hansemannn I fixed it to build for modules, couldn't build tho on my Silicon machine, but it the fix for sure went after that stage.

m1ga · 2024-09-14T11:15:15Z

awesome! SDK builds, apps build, modules build 👍 We are getting closer.

fix for hyperloop apps: chore: add namespace for gradle8 update hyperloop.next#392
small workflow update in chore(android): forward --sdk in module build process #14112 (modules build fine, but when you start a example app build in a module it won't forward the --sdk 12.6.0 parameter)

m1ga · 2024-09-14T16:16:08Z

one thing we'll need to tell the module developers: minSdk 12.6.0 is required when you build modules with this SDK as it is building with a higher Java version. The other way (old modules in 12.6.0 apps) works fine.

AbdullahFaqeir · 2024-09-14T16:18:26Z

one thing we'll need to tell the module developers: minSdk 12.6.0 is required when you build modules with this SDK as it is building with a higher Java version. The other way (old modules in 12.6.0 apps) works fine.

@m1ga while generating the manifest file?

m1ga · 2024-09-14T16:22:23Z

when building an app with a module that was build with this PR you'll see
´Unsupported class file major version 61as the module was build with JAVA_17 and the app is trying to build with JAVA_11 (current 12.4.0). But since we have theminSdk` value in the module manifest it's fine. The developer just have to update it when using 12.6.0 to build the module

AbdullahFaqeir · 2024-09-14T16:31:33Z

when building an app with a module that was build with this PR you'll see ´Unsupported class file major version 61as the module was build with JAVA_17 and the app is trying to build with JAVA_11 (current 12.4.0). But since we have theminSdk` value in the module manifest it's fine. The developer just have to update it when using 12.6.0 to build the module

@m1ga Exactly!

AbdullahFaqeir · 2024-09-14T17:09:13Z

@m1ga @hansemannn I believe the PR is ready to be merged?

m1ga · 2024-09-14T17:19:21Z

@AbdullahFaqeir I think we should add the new hyperloop module to this PR too as it is needed for it to work. For that tidev/hyperloop.next#391 should build the Github repo so we have a release version. If it is released we can change the version number in:

titanium-sdk/support/module/packaged/modules.json

Lines 57 to 58 in fac2c4b

    
           "url": "https://github.com/tidev/hyperloop.next/releases/download/v7.0.6/hyperloop-7.0.6.zip", 
        
           "integrity": "sha512-ZHmm7GINiCyrjvNMn232G1Tkby6PhwsmSxPZlPNDWH4jRn6iCpjIqX1Ha12MBedma01a4hlvARLaiUQ9j3SPow=="

so it will be delivered with the SDK

m1ga

My tests look good:

building the SDK ✔️
building app with multiple existing modules with this SDK ✔️
building modules and the included example app ✔️
building hyperloop-examples ✔️
building kitchensink-v2 ✔️

android/templates/module/generated/build.gradle

android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIButton.java

cb1kenobi · 2024-09-16T14:47:34Z

Tested on Windows 11, Titanium CLI 7.1.4, Node.js 22.6.0, Java 20.0.1 and my dead simple app (no modules) works great!

…tanium-sdk into gradle-upgrade

hansemannn

LGTM!

AbdullahFaqeir · 2024-09-17T07:22:46Z

LET'S GOOOO 🚀🚀🚀

cb1kenobi · 2024-09-17T15:35:53Z

Excellent work!

AhmedMSayed · 2024-11-02T17:00:37Z

Halla walla, That's Awesome @AbdullahFaqeir you saved my day

chore(android): let there be gradle 8

f042d37

chore(android): fixed deprecations in kroll-apt project chore(android): made kroll-apt incremental to enhance build time

m1ga self-requested a review March 23, 2024 20:25

m1ga requested changes Mar 23, 2024

View reviewed changes

fix(android): revert change to java files

ac5b751

fix(android): gradle 8 compatibility update to template build.gradle fix(android): revert dependency updates fix(android): revert minSdk and targetSdk

AbdullahFaqeir commented Mar 24, 2024

View reviewed changes

fix(android): kitchensink-app not running after gradle 8

477d708

fix(android): update _build.js & _buildModule.js for new gradle

AbdullahFaqeir requested a review from m1ga March 26, 2024 17:37

m1ga mentioned this pull request Mar 26, 2024

Android: update gradle #13579

Closed

m1ga changed the title ~~chore(android): let there be gradle 8~~ chore(android): gradle 8 Mar 26, 2024

m1ga self-assigned this Mar 26, 2024

m1ga mentioned this pull request Mar 28, 2024

Android update hansemannn/titanium-stripe#4

Open

cb1kenobi reviewed May 1, 2024

View reviewed changes

hansemannn and others added 5 commits September 12, 2024 17:30

Update android/app/build.gradle

dba4f6d

Co-authored-by: Chris Barber <[email protected]>

Update android/templates/build/ti.constants.gradle

2d74038

Co-authored-by: Chris Barber <[email protected]>

Update android/titanium/build.gradle

d536804

Co-authored-by: Chris Barber <[email protected]>

Update android/titanium/build.gradle

a868e4e

Co-authored-by: Chris Barber <[email protected]>

Update android/untar.gradle

8ec670a

Co-authored-by: Chris Barber <[email protected]>

hansemannn requested changes Sep 12, 2024

View reviewed changes

Update android/titanium/build.gradle

48db12b

Co-authored-by: Chris Barber <[email protected]>

Merge branch 'master' into gradle-upgrade

af0a4f3

m1ga reviewed Sep 13, 2024

View reviewed changes

android/app/build.gradle Show resolved Hide resolved

m1ga reviewed Sep 13, 2024

View reviewed changes

android/gradle.properties Outdated Show resolved Hide resolved

fix material.r

258b9fa

github action

9c4a2b4

hansemannn reviewed Sep 13, 2024

View reviewed changes

android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIButton.java Outdated Show resolved Hide resolved

m1ga and others added 3 commits September 13, 2024 17:11

optimize material imports

50eae21

optimize material imports

8eba63d

fix(android): fix module building

00227a6

m1ga mentioned this pull request Sep 14, 2024

chore: add namespace for gradle8 update tidev/hyperloop.next#392

Merged

Merge branch 'master' into gradle-upgrade

aeaaea9

Merge branch 'master' into gradle-upgrade

e4e178a

Merge branch 'master' into gradle-upgrade

14f3bf4

m1ga self-requested a review September 16, 2024 11:55

m1ga reviewed Sep 16, 2024

View reviewed changes

android/templates/module/generated/build.gradle Outdated Show resolved Hide resolved

android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIButton.java Outdated Show resolved Hide resolved

AbdullahFaqeir requested review from hansemannn and m1ga September 16, 2024 21:53

AbdullahFaqeir added 2 commits September 17, 2024 04:04

fix(android): bump ndk version for generated modules

81f1392

Merge branch 'gradle-upgrade' of https://github.com/AbdullahFaqeir/ti…

952eeea

…tanium-sdk into gradle-upgrade

hansemannn approved these changes Sep 17, 2024

View reviewed changes

m1ga approved these changes Sep 17, 2024

View reviewed changes

hansemannn merged commit 50d8604 into tidev:master Sep 17, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(android): gradle 8 #14014

chore(android): gradle 8 #14014

AbdullahFaqeir commented Mar 23, 2024

m1ga left a comment

AbdullahFaqeir left a comment

m1ga commented Mar 26, 2024

cb1kenobi left a comment

m1ga commented May 1, 2024

hansemannn left a comment •

edited

Loading

AbdullahFaqeir commented Sep 13, 2024 •

edited

Loading

AbdullahFaqeir commented Sep 13, 2024

m1ga commented Sep 13, 2024 •

edited

Loading

hansemannn commented Sep 13, 2024

m1ga commented Sep 13, 2024

AbdullahFaqeir commented Sep 13, 2024

m1ga commented Sep 14, 2024

m1ga commented Sep 14, 2024

AbdullahFaqeir commented Sep 14, 2024

m1ga commented Sep 14, 2024

AbdullahFaqeir commented Sep 14, 2024

AbdullahFaqeir commented Sep 14, 2024

m1ga commented Sep 14, 2024

m1ga left a comment

cb1kenobi commented Sep 16, 2024

hansemannn left a comment

AbdullahFaqeir commented Sep 17, 2024

cb1kenobi commented Sep 17, 2024

AhmedMSayed commented Nov 2, 2024

chore(android): gradle 8 #14014

chore(android): gradle 8 #14014

Conversation

AbdullahFaqeir commented Mar 23, 2024

m1ga left a comment

Choose a reason for hiding this comment

AbdullahFaqeir left a comment

Choose a reason for hiding this comment

m1ga commented Mar 26, 2024

cb1kenobi left a comment

Choose a reason for hiding this comment

m1ga commented May 1, 2024

hansemannn left a comment • edited Loading

Choose a reason for hiding this comment

AbdullahFaqeir commented Sep 13, 2024 • edited Loading

AbdullahFaqeir commented Sep 13, 2024

m1ga commented Sep 13, 2024 • edited Loading

hansemannn commented Sep 13, 2024

m1ga commented Sep 13, 2024

AbdullahFaqeir commented Sep 13, 2024

m1ga commented Sep 14, 2024

m1ga commented Sep 14, 2024

AbdullahFaqeir commented Sep 14, 2024

m1ga commented Sep 14, 2024

AbdullahFaqeir commented Sep 14, 2024

AbdullahFaqeir commented Sep 14, 2024

m1ga commented Sep 14, 2024

m1ga left a comment

Choose a reason for hiding this comment

cb1kenobi commented Sep 16, 2024

hansemannn left a comment

Choose a reason for hiding this comment

AbdullahFaqeir commented Sep 17, 2024

cb1kenobi commented Sep 17, 2024

AhmedMSayed commented Nov 2, 2024

hansemannn left a comment •

edited

Loading

AbdullahFaqeir commented Sep 13, 2024 •

edited

Loading

m1ga commented Sep 13, 2024 •

edited

Loading