feat(android): defaultLang option in tiapp.xml #14027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
requested changes
Apr 30, 2024
Co-authored-by: Chris Barber <[email protected]>
|
docs: tidev/titanium-docs#217 |
cb1kenobi
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you create an app that only uses one language that isn't EN it won't create the correct string structure. In the build file EN is set to always be the default language.
This PR will allow you to set
<defaultLang>de</defaultLang>inside the tiapp.xml file so it will use a different language as the default file. If it is not set it will still useenTest:
<defaultLang>de</defaultLang>setting in tiapp.xmlNote: only tested and added it to Android as iOS already has a plist entry for default lang.