feat(android): flatten ListView layout#14037
Merged
hansemannn merged 9 commits intomasterfrom Aug 26, 2024
Merged
Conversation
Collaborator
|
@prashantsaini1 If you have time, it'd be great to test this with our app to see if it works well, as we also use some complex list views. You can grab a build from Github Actions |
hansemannn
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current layout of the ListView/RecyclerView is a nested RelativeLayout:

Having a flatter layout is always better for RecyclerView performance.
This PR will use the ConstraintLayout and removes the nested layers:

Changes
Testing
I'm testing it with KitchenSink as that has 4 different ListView examples (editable, marker, multi select, normal with accessoryTypes) and this code: