Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): expose contentOffset getter in TableView/ListView #14058

Merged
merged 1 commit into from
Jun 15, 2024
Merged

feat(android): expose contentOffset getter in TableView/ListView #14058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/modules/ui/src/java/ti/modules/titanium/ui/TableViewProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ public String getApiName()
return "Ti.UI.TableView";
}

// NOTE: For internal use only.
@Kroll.getProperty
public KrollDict getContentOffset()
{
final TiTableView tableView = getTableView();
Expand Down
2 changes: 1 addition & 1 deletion android/modules/ui/src/java/ti/modules/titanium/ui/widget/listview/ListViewProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ public void setActivity(Activity activity)
}
}

// NOTE: For internal use only.
@Kroll.getProperty
public KrollDict getContentOffset()
{
final TiListView listView = getListView();
Expand Down
6 changes: 6 additions & 0 deletions apidoc/Titanium/UI/ListView.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,6 +684,12 @@ properties:
ipad: 3.2.0
platforms: [android, iphone, ipad, macos]

- name: contentOffset
summary: X and Y coordinates to which to reposition the top-left point of the content region.
type: Point
since: {android: "12.4.0"}
platforms: [android]

- name: disableBounce
summary: Determines whether the scroll-bounce of the list view should be disabled.
description: |
Expand Down
6 changes: 6 additions & 0 deletions apidoc/Titanium/UI/TableView.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,6 +1073,12 @@ properties:
type: [String, Titanium.UI.Color]
default: transparent on non-iOS platforms, white on the iOS platform

- name: contentOffset
summary: X and Y coordinates to which to reposition the top-left point of the content region.
type: Point
since: {android: "12.4.0"}
platforms: [android]

- name: data
summary: Rows of the table view.
type: [Array<Titanium.UI.TableViewRow>, Array<Titanium.UI.TableViewSection>]
Expand Down
Loading