Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): fix tintColor and activeTintColor in a TabbedBar #14088

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Jul 23, 2024

fixes #14087

tintColor and activeTintColor are not working in a TabbedBar:

var win = Ti.UI.createWindow();
var bb1 = Ti.UI.createTabbedBar({
	top: 10,
  	width : Ti.UI.FILL,
  	labels: [{label:"test", image:"appicon.png"}, {label:"test", image:"appicon.png"}, {label:"test", image:"appicon.png"}]
});
win.add(bb1);


var bb2 = Ti.UI.createTabbedBar({
  	width : Ti.UI.FILL,
  	tintColor : '#D4AF37',
  	activeTintColor : '#f00',
  	labels: [{label:"test", image:"appicon.png"}, {label:"test", image:"appicon.png"}, {label:"test", image:"appicon.png"}]
});
win.add(bb2);

var btn = Ti.UI.createButton({title:"select", bottom: 10});
win.add(btn);
btn.addEventListener("click", function(e){
	bb1.index = 1;
	bb2.index = 1;
})
win.open();

12.4.0:
Screenshot_20240723-181235

After PR:
Screenshot_20240723-181527

@hansemannn hansemannn merged commit 2e92f1d into master Aug 20, 2024
6 checks passed
@hansemannn hansemannn deleted the androidTintTabbar branch August 20, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android: TabbedBar icon doesn't tint like the label.
3 participants