Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sdk build on windows needs shell: true to run batch files #14095

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

cb1kenobi
Copy link
Contributor

Not sure if it's a Node 22 thing or what, but I get a EINVAL error doing npm run cleanbuild:local because it spawns a batch file which requires a shell to be true.

Copy link
Collaborator

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a Windows PC to verify, but the change does at least not break macOS, so if it helps on Windows, it's fine.

@m1ga
Copy link
Contributor

m1ga commented Aug 15, 2024

I'll get my VM setup to build the SDK and check it

@m1ga
Copy link
Contributor

m1ga commented Aug 15, 2024

yes, it's a node 22 thing. With node 20 I didn't see that error. When I updated I saw:

Bildschirmfoto_20240815_121758
(don't have copy & paste running, so screenshot was quicker 😄 )

After this PR it starting building again. It's still at 48% for 5mins now but I blame the VM for that... Update: 10mins later and it finished building 😄

Building with 22.5.0 under linux still works fine with the current master but I see many

(node:24216) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

warnings during the build process.

Copy link
Contributor

@m1ga m1ga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build starts on Windows again after applying this PR (node 22.6.0)

@cb1kenobi
Copy link
Contributor Author

Awesome, thank you guys for the review! Let's go!

@cb1kenobi cb1kenobi merged commit f3e5a0b into tidev:master Aug 15, 2024
5 checks passed
@cb1kenobi cb1kenobi deleted the fix-sdk-build-windows branch August 15, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants