New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More snapshots #271

Merged

EmilHvitfeldt merged 3 commits into main from more-snapshots

Sep 24, 2024

Member

EmilHvitfeldt commented Sep 24, 2024

Ref: tidymodels/recipes#1375

This PR:

switched from expect_warning() and expect_message() to expect_snapshot()
removed classed expect_error() and switched to expect_snapshot(error = TRUE)
Switched from expect_error(..., NA) to expect_no_error(). Can't do expect_no_condition() due to dplyr_regroup signal
Switched rest of expect_error() to expect_snapshot(error = TRUE)

EmilHvitfeldt added 3 commits

September 24, 2024 14:11


          no more checking classes errors

7d7d1a5


          no more expect_warning()

d0bfb7c


          no more expect_error()

2ee21c2

EmilHvitfeldt merged commit 60999a6 into main

7 checks passed

EmilHvitfeldt deleted the more-snapshots branch

September 24, 2024 22:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet