Skip to content

Conversation

@MichaelChirico
Copy link
Contributor

Closes #1529

I could go for an assist on writing a regression test, I couldn't quite put all the pieces together. How do I link a custom translation to a simulated connection?

Also LMK if you want more tests covering the switch to ls_all() for the other cases.

@MichaelChirico
Copy link
Contributor Author

btw, this is not ~quite working, and I'm not sure why -- after this change, the translation looks like (from memory):

translate_sql(.POSIXct(0), con=con)
# <SQL> 1970-01-01 00:00:00

i.e., it's actively evaluated .POSIXct(0) instead of translating it as intended. That's a different behavior than before ("no translation found --> attempt to pass it through to SQL directly"), but not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

translate_sql() fails when the target for translation starts with a dot

1 participant