Fix cte quoting issues #1560
Open
Fix cte quoting issues #1560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1559
Here are my proposed fixes for the CTE issues I listed in #1559
This PR includes the work I did for #1558 because I couldn't get CTEs working without those changes.
While I was working on fixing the quoting issues, I noticed that there was a TODO to use
querylist_reuse_queryforflatten_query.union_queryandflatten_query.multi_join_queryand I believe I have that part working as well.Not only does the included test pass, but the far more complicated, real-life use case from which I derived the test also works now.