Refresh coalesce() on top of vctrs::vec_case_when()
#7725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Five goals:
coalesce()usingvctrs::vec_case_when()coalesce(1, NULL, "x"), where the reported index was off due to compacting outNULLtoo earlyNULLnames_as_error_names(), which is no longer required with the C impl ofvec_case_when()(it falls out naturally when you rewrite in C)coalesce()I'm happy that I can explain where all of these remaining allocations come from: