Store expr not quo for last_dplyr_warnings()
#7750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
approved these changes
Oct 30, 2025
| env( | ||
| error_name = names(dots)[[i]], | ||
| error_quo = dots[[i]], | ||
| error_expr = quo_get_expr(dots[[i]]), |
Member
There was a problem hiding this comment.
I haven't looked where the quosure is created and if there might be injected quosures in there. If that's the case, the safer operation is quo_squash(). It recursively unwraps quosures (and so has some overhead).
Member
Author
There was a problem hiding this comment.
For our purposes, in the only place we previously used error_quo we were extracting the expression with expr <- quo_get_expr(quo), so I think this is safe enough (at the very least it retains current behavior)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7649
Issue is described in #7649 (comment)