Skip to content

Conversation

@hadley
Copy link
Member

@hadley hadley commented Apr 3, 2025

Starting with chat_openai() and backends.

@hadley hadley requested a review from atheriel April 3, 2025 22:51
@atheriel
Copy link
Collaborator

atheriel commented Apr 8, 2025

This appears to break chat_snowflake() at least:

> chat <- chat_snowflake()
Using model = "llama3.1-70b".
> chat$chat("Tell me a joke in the form of a SQL query.")
Error in `req_perform_connection()` at elmer/R/httr2.R:37:5:
! Failed to parse error body with method defined in
  `req_error()`.
Caused by error in `resp_body_json()` at elmer/R/provider-snowflake.R:95:32:
! Unexpected content type "NA".
• Expecting type "application/json" or suffix "json".

@atheriel
Copy link
Collaborator

atheriel commented Apr 8, 2025

chat_databricks() has issues as well:

> chat <- chat_databricks()
Using model = "databricks-dbrx-instruct".
> chat$chat("Tell me a joke in the form of a SQL query.")
Error in `req_perform_connection()` at elmer/R/httr2.R:37:5:
! HTTP 400 Bad Request.
• Bad request: json: unknown field "stream_options"
Show Traceback

@atheriel
Copy link
Collaborator

atheriel commented Apr 8, 2025

chat_azure_openai() with Entra ID credentials continues to work for me, though.

@hadley hadley mentioned this pull request Apr 9, 2025
2 tasks
@hadley
Copy link
Member Author

hadley commented Apr 9, 2025

I have a confirmed fix for databricks, and I'm pretty sure I've identified the snowflake issue. Assuming all the tests pass, I'm going to merge this, assuming that you or I will come back to properly test snowflake prior to release.

@hadley hadley merged commit 8a13a15 into main Apr 9, 2025
8 of 9 checks passed
@hadley hadley deleted the base-request branch April 9, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants