refactor(live_browser): Use shinychat::chat_app()
#435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Do you have any suggestions about how to handle the mutual dependencies problem? I'm assuming the root cause of this test failure is that after this change ellmer depends on shinychat (in Suggests) and shinychat depends on ellmer (in Imports). |
Member
|
Just keep shinychat in Suggests? |
Collaborator
Author
Oh shoot, I didn't intentionally move it; I missed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397
Introduces a dev dependency on shinychat v0.1.1.9001+ that we'll need to resolve when shinychat is released, prior to next ellmer release. (If you'd like me to refactor to maintain back compat, just let me know.)
The NEWS bullet also advertises the new
shinychat::chat_mod_ui()andshinychat::chat_mod_server()functions that can be used to easily create a batteries-included chat interface from an ellmerChatobject.