Redact API keys when saving to disk #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the magic of weak refs. Fixes #534
simonpcouch
approved these changes
May 30, 2025
There was a problem hiding this comment.
SO GOOD YAY
Just to make sure my mental model is right here—this doesn't cause any hiccups with sending chat apps into production, right? e.g. in Joe's ellmer assistant, the weak reference is created in the server each time the app starts up?
|
Right, it shouldn't because you're not saving the chat to RDS and reloading it, you're creating it live each time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the magic of weak refs. Fixes #534