New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new documentation #164

Merged

knzo25 merged 395 commits into tier4/universe from feature/new_api_documentation

Sep 24, 2024

Collaborator

knzo25 commented Apr 22, 2024

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

knzo25 requested a review from vividf

April 22, 2024 10:31

knzo25 self-assigned this

knzo25 marked this pull request as draft

April 22, 2024 10:31

Collaborator Author

knzo25 commented Apr 22, 2024

Note to self. Rebase if needed

vividf requested changes

View reviewed changes

Contributor

vividf left a comment

LGTM! only one some error that need to fix

sensor/tag_based_sfm_calibrator/README.md Outdated Show resolved Hide resolved

Collaborator Author

knzo25 commented Apr 22, 2024

@vividf
LGTM does not apply in this case. We will put all of our documentation here before merging. hence draft

knzo25 mentioned this pull request

extrinsic_calibration_manager can‘t find! #169

Closed

knzo25 commented

View reviewed changes

sensor/docs/tutorials/marker_radar_lidar_calibrator.md Outdated Show resolved Hide resolved

Collaborator Author

knzo25 commented Apr 25, 2024 •

edited

Loading

@vividf
General comments:

There are several grammar/spelling/redaction/cohesion mistakes. Please, read the documents again, and use a tool like grammarly (you can use it in vscode)
During the tutorials, there are recommendations on how to to things good, but things that could go wrong should also be remarked. At the end of the documentation and tutorial, there are no or not enough recommendations / tips / common problems. If there were mentioned in the main document, they should also be put again at the end for emphasis (people usually skip to the end anyways)
When possible, center the images. Not are clearly not
In the PNP calibrator, for example, when the image does not appear in the UI, the data may not be synchronized

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 requested a review from vividf

April 25, 2024 04:59

knzo25 marked this pull request as ready for review

April 25, 2024 04:59

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

knzo25 commented

View reviewed changes

sensor/tag_based_pnp_calibrator/README.md Outdated Show resolved Hide resolved

vividf added 10 commits

July 17, 2024 19:10


          chore: keyframe markers and the

232658f

Signed-off-by: vividf <[email protected]>


          chore: extracted from

07225d6

Signed-off-by: vividf <[email protected]>


          chore: remove ()

2a1aa92

Signed-off-by: vividf <[email protected]>


          chore: add pro-tips

caf5c96

Signed-off-by: vividf <[email protected]>


          chore: fix step 2 calibration data preparation

f05e4cf

Signed-off-by: vividf <[email protected]>


          chore: add processing

Signed-off-by: vividf <[email protected]>


          chore: fix data selection

9956c93

Signed-off-by: vividf <[email protected]>


          chore: fix more data selection

6ab8d87

Signed-off-by: vividf <[email protected]>


          chore: would be to identical

c51e411

Signed-off-by: vividf <[email protected]>


          chore: could get to obtain

3c26117

Signed-off-by: vividf <[email protected]>

Collaborator Author

knzo25 commented Jul 22, 2024

@vividf
It has been a week since the review, and still several comments left addressed. We have talked again and again about priorities

This was referenced Jul 25, 2024

lidar radar calib #182

Closed

Issue with rosdep installation of Autoware calibration tools #183

Closed

knzo25 added 4 commits

August 13, 2024 07:37


          fix: fixed dependencies (due to autoware's autoware prefix)

97f5859

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>


          chore: moved the sensor calibrator manager outside of the calibrators…

ff6c871

… folder (other changes are pre-commit induced)

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>


          chore: updated the use of the kalman filter implementation since it w…

1dfc8d7

…as moved into the autoware namespace

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>


          fix: updated the use of the decompressor

52416ae

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

knzo25 mentioned this pull request

Issue with rosdep installation of Autoware calibration tools #183 #187

Closed

knzo25 and others added 7 commits

September 3, 2024 15:24


          chore: adapted to the new way of using lidartag

0e5d80f

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>


          fix: init tf tree visualization (#188)

5a7f335

* fix: init tf tree visualization

Signed-off-by: vividf <[email protected]>

* chore: fix error

Signed-off-by: vividf <[email protected]>

---------

Signed-off-by: vividf <[email protected]>


          fix(intrinsic_camera_calibrator): fixed dot board detector (#189)

48a9072

fix: forgot to add a fix to the dot board detector

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>


          docs: candidate for the final documentation of the new api

64d6ad0

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>


          chore: fixed dead links and spelling

3b8a2f0

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>


          chore: fixed missing mispell in a package name

61c95dd

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>


          chore: fixed missing dead link

6f78049

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

knzo25 merged commit 69bb747 into tier4/universe

6 of 8 checks passed

Collaborator Author

knzo25 commented Sep 24, 2024

I will be force merging this since this was going nowhere and we needed a stable branch eons ago

knzo25 deleted the feature/new_api_documentation branch

September 24, 2024 12:33

knzo25 mentioned this pull request

standalone repo with rosbag simulation #185

Closed

vividf restored the feature/new_api_documentation branch

September 25, 2024 02:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet