Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update x1 settings for ground plane calibration #210

Conversation

1222-takeshi
Copy link
Contributor

Description

The sensor configuration of X1 is sparse, and using a wide range of pointclouds would result in “Iteration failed”.
Therefore, we narrowed the range of the cropbox filter.

Related links

TIER IV INTERNAL LINK

Tests performed

Tested on real vehicle.
output by sensor_calibration_manager

base_link:
  sensor_kit_base_link:
    x: 0.632681
    y: -0.014855
    z: 2.160467
    roll: 0.007074
    pitch: 0.013207
    yaw: -0.000000

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Collaborator

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

一応ケンゾウさんにも確認してもらうためreviewerに入れました

Copy link
Collaborator

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@t4-k-higashimoto t4-k-higashimoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1222-takeshi 1222-takeshi merged commit a3dd584 into tier4/universe Nov 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants