feat: response time timeseries #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yu-taro- <[email protected]>
Signed-off-by: yu-taro- <[email protected]>
Signed-off-by: yu-taro- <[email protected]>
Signed-off-by: yu-taro- <[email protected]>
Signed-off-by: yu-taro- <[email protected]>
…re changed and mock tests were added and modified because of the points raised Signed-off-by: yu-taro- <[email protected]>
Signed-off-by: yu-taro- <[email protected]>
Signed-off-by: yu-taro- <[email protected]>
Signed-off-by: yu-taro- <[email protected]>
Signed-off-by: yu-taro- <[email protected]>
Signed-off-by: taro-yu <[email protected]>
Signed-off-by: taro-yu <[email protected]>
taro-yu
force-pushed
the
feat/path_response_time_TimeSeries
branch
from
d27018d
to
7b2b4a8
Compare
added 4 commits
September 1, 2023 17:47
Signed-off-by: taro-yu <[email protected]>
Signed-off-by: taro-yu <[email protected]>
taro-yu
force-pushed
the
feat/path_response_time_TimeSeries
branch
from
f3feb87
to
705d9fa
Compare
Signed-off-by: taro-yu <[email protected]>
taro-yu
force-pushed
the
feat/path_response_time_TimeSeries
branch
from
4d4ed11
to
10b319b
Compare
added 3 commits
September 2, 2023 22:39
Signed-off-by: taro-yu <[email protected]>
Signed-off-by: taro-yu <[email protected]>
Signed-off-by: taro-yu <[email protected]>
rokamu623
requested changes
Sep 4, 2023
added 4 commits
September 5, 2023 05:11
Signed-off-by: taro-yu <[email protected]>
Signed-off-by: taro-yu <[email protected]>
rokamu623
previously approved these changes
Sep 6, 2023
added 3 commits
September 7, 2023 17:18
taro-yu
force-pushed
the
feat/path_response_time_TimeSeries
branch
from
a17e870
to
244f591
Compare
taro-yu
changed the title
added 8 commits
September 7, 2023 23:56
Signed-off-by: taro-yu <[email protected]>
Signed-off-by: taro-yu <[email protected]>
Signed-off-by: taro-yu <[email protected]>
Signed-off-by: taro-yu <[email protected]>
Signed-off-by: taro-yu <[email protected]>
Signed-off-by: taro-yu <[email protected]>
Signed-off-by: taro-yu <[email protected]>
nabetetsu
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
I have confirmed that the PR works as exppected as below results.
LGTM 👍
rt2-823-result.zip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR create the API to plot timeseries graph of response time.
This API supports three cases: 'best', 'worst', and 'all'
Related links
Jira: https://tier4.atlassian.net/browse/RT2-823
Notes for reviewers
Please use this zip to check actions.
checkfiles.zip
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.