Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stacked bar worst-in-input and all #339

Merged

Conversation

rokamu623
Copy link
Contributor

@rokamu623 rokamu623 commented Sep 14, 2023

Description

implement 'worst-in-input' and 'all' option for stacked bar
image

Related links

Jira: https://tier4.atlassian.net/browse/RT2-862

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: rokamu623 <[email protected]>
Signed-off-by: rokamu623 <[email protected]>
nabetetsu
nabetetsu previously approved these changes Sep 14, 2023
Copy link
Collaborator

@nabetetsu nabetetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

Both all and worst-in-input option are well visualized as we expected.

rt2-862 drawio

Copy link
Contributor

@bopeng-saitama bopeng-saitama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rokamu623 rokamu623 merged commit db4bcf3 into tier4:main Sep 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants