Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename option of ResponseTime #355

Merged
merged 8 commits into from
Sep 27, 2023
Merged

fix: rename option of ResponseTime #355

merged 8 commits into from
Sep 27, 2023

Conversation

rokamu623
Copy link
Contributor

@rokamu623 rokamu623 commented Sep 25, 2023 •
edited by nabetetsu
Loading

Description

The current option names for ResponseTime diverge from the intuitive image.
The option names have been changed as follows:

  • worst -> worst-with-external-latency
  • worst-in-input -> worst

image

Related links

Jira: https://tier4.atlassian.net/browse/RT2-888

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@rokamu623 rokamu623 self-assigned this Sep 25, 2023
@rokamu623 rokamu623 changed the title fix: timeseries histogram option fix: option name of ResponseTime Sep 25, 2023
@rokamu623 rokamu623 changed the title fix: option name of ResponseTime fix: rename option of ResponseTime Sep 25, 2023
bopeng-saitama
bopeng-saitama previously approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@bopeng-saitama bopeng-saitama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nabetetsu
nabetetsu approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@nabetetsu nabetetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that all target options work as expected.
LGTM 👍

@rokamu623 rokamu623 merged commit 9c2b674 into tier4:main Sep 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabetetsu nabetetsu nabetetsu approved these changes

@bopeng-saitama bopeng-saitama bopeng-saitama left review comments

Assignees

@rokamu623 rokamu623

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rokamu623 @bopeng-saitama @nabetetsu