Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed type_check_decorator #513

Merged
merged 10 commits into from
Sep 2, 2024
Merged

fix: fixed type_check_decorator #513

merged 10 commits into from
Sep 2, 2024

Conversation

miyakoshi-dev
Copy link
Contributor

@miyakoshi-dev miyakoshi-dev commented Jun 27, 2024 •
edited by xygyo77
Loading

Description

Fixed type_check_decorator

Related links

https://tier4.atlassian.net/browse/RT2-1532

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@miyakoshi-dev miyakoshi-dev requested a review from ymski June 27, 2024 06:37
@miyakoshi-dev miyakoshi-dev changed the title fixed type_check_decorator fix: fixed type_check_decorator Jul 9, 2024
@ymski
Copy link
Contributor

ymski commented Aug 20, 2024 •
edited
Loading

@miyakoshi-dev
The for loop is being run by index, is it possible to change it to use elements? (at _change_loc_tuple() and _change_loc_tuple_varargs_name())
This is just a point for readability, not for functionality.

ymski
ymski previously approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ymski
ymski requested changes Aug 30, 2024
View reviewed changes
src/test/common/test_type_check_decorator.py Outdated Show resolved Hide resolved
src/test/common/test_type_check_decorator.py Outdated Show resolved Hide resolved
src/test/common/test_type_check_decorator.py Outdated Show resolved Hide resolved
ymski
ymski approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymski ymski requested a review from xygyo77 September 2, 2024 00:40
xygyo77
xygyo77 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@xygyo77 xygyo77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

LGTM

@miyakoshi-dev miyakoshi-dev merged commit 2ca8d9b into tier4:main Sep 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymski ymski ymski approved these changes

@xygyo77 xygyo77 xygyo77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miyakoshi-dev @ymski @xygyo77