feat: merge using the source timestamp #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
h-suzuki-isp
force-pushed
the
take_use_latest_message
branch
from
ecac58e
to
219f145
Compare
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
This reverts commit 33a6232.
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
h-suzuki-isp
force-pushed
the
take_use_latest_message
branch
from
408a426
to
44113f4
Compare
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
ymski
reviewed
Jul 29, 2024
Co-authored-by: ymski <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Co-authored-by: ymski <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
ymski
reviewed
Aug 6, 2024
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
ymski
requested changes
Aug 6, 2024
ymski
reviewed
Aug 6, 2024
Co-authored-by: ymski <[email protected]>
Co-authored-by: ymski <[email protected]>
Co-authored-by: ymski <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
Signed-off-by: h-suzuki <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapted the implementation to support calling subscription->take at the intended timing to retrieve the message, rather than using subscription_callback. In this case, modified the code to merge records based on source_timestamp.
Related links
Notes for reviewers
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.