fix: subscription take #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
…factor-subscription-take
ymski
reviewed
Oct 22, 2024
…callback, and skip the merge process. Signed-off-by: ISP akm <[email protected]>
ymski
reviewed
Oct 29, 2024
src/test/runtime/test_path.py
Outdated
| @@ -803,7 +798,7 @@ def test_take_impl_case_include_last_callback(self, mocker, caplog): | |||
| return_value=RecordsCppImpl( | |||
| [], | |||
| [ | |||
| ColumnValue(f'{topic1}/callback_start_timestamp'), | |||
| ColumnValue(f'{topic1}/source_timestamp'), | |||
There was a problem hiding this comment.
to_path_end_records always returns the column [xxx/callback_start, xxx/callback_end].
It is not appropriate to use source_timestamp as the column name.
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
miyakoshi-dev
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify the following two points
Related links
https://tier4.atlassian.net/browse/RT2-1838
Notes for reviewers
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.