Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude "struct/__init__.py" from test_frake8.py #541

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

xygyo77
Copy link
Contributor

@xygyo77 xygyo77 commented Nov 7, 2024

Description

Exclude struct/init.py from test_frake8.py.

Related links

https://tier4.atlassian.net/browse/RT2-1985

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xygyo77 xygyo77 requested a review from ymski November 7, 2024 07:30
Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new check for built-in module name shadowing (A005) has been added in flake8-builtins v2.5.0.  (CHANGELOG)

By applying this PR, it has been confirmed that the A005 related issue is no longer raised.
LGTM.

Copy link
Contributor

@miyakoshi-dev miyakoshi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[compare] ========== Result ==========
[compare] 1/3 file existence matches
[compare] OK. file existence matches
[compare] 2/3 yaml files
[compare] OK. yaml matches
[compare] 3/3 PNG files
[compare] OK. PNG matches
[compare] ====== ALL OK ==============
LGTM

@xygyo77 xygyo77 merged commit dcea390 into tier4:main Nov 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants