Skip to content
This repository was archived by the owner on Aug 27, 2021. It is now read-only.

Conversation

@KeisukeShima
Copy link
Collaborator

What kinds of PR

  • New feature
  • Improve feature
  • Bug fix

What is this PR

How to check this PR

@github-actions
Copy link

📊 Code Metrics Report

Branch Metrics
This PR code-metrics.html
main code-metrics.html

Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is under draft, but will leave some comments.

trajectory.points.push_back(traj_point);
}
return trajectory;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should define functions like calcYaw(p1, p2) and createQuaternionFromYaw(yaw).

using namespace std::chrono_literals;

// FIXME: Rename function name
Trajectory convertPointsToTrajectoryWithYaw2(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is Yaw2?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary name and will be changed later.

Kenji Miyake added 4 commits May 12, 2021 02:35
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #30 (8914056) into main (0eccfbf) will increase coverage by 9.20%.
The diff coverage is 38.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   25.71%   34.91%   +9.20%     
==========================================
  Files          16       15       -1     
  Lines        1015      885     -130     
  Branches      569      506      -63     
==========================================
+ Hits          261      309      +48     
+ Misses        388      157     -231     
- Partials      366      419      +53     
Flag Coverage Δ
unittests 34.91% <38.69%> (+9.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ine/include/obstacle_stop_planner/debug_marker.hpp 100.00% <ø> (ø)
...cle_stop_planner/util/create_vehicle_footprint.hpp 57.14% <0.00%> (ø)
obstacle_stop_planner_refine/src/node.cpp 11.11% <11.11%> (-38.89%) ⬇️
...de/obstacle_stop_planner/util/parameter_helper.hpp 14.28% <14.28%> (ø)
obstacle_stop_planner_refine/src/debug_marker.cpp 35.84% <25.00%> (+13.89%) ⬆️
...top_planner_refine/src/adaptive_cruise_control.cpp 17.67% <27.08%> (+7.52%) ⬆️
...ner_refine/test/src/test_obstacle_stop_planner.cpp 27.50% <27.50%> (ø)
...bstacle_stop_planner_refine/test/src/test_node.cpp 31.81% <32.25%> (ø)
..._stop_planner_refine/src/obstacle_stop_planner.cpp 53.64% <53.68%> (+28.19%) ⬆️
...ude/obstacle_stop_planner/obstacle_point_cloud.hpp 29.16% <66.66%> (-9.97%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eccfbf...8914056. Read the comment docs.

Signed-off-by: Kenji Miyake <[email protected]>
@kenji-miyake
Copy link
Contributor

@KeisukeShima Replaced unnecessary emplace_back with push_back because push_back is safer.
https://yasenh.github.io/post/cpp-diary-1-emplace_back/
https://abseil.io/tips/112

Signed-off-by: Kenji Miyake <[email protected]>
Kenji Miyake added 2 commits May 20, 2021 00:52
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Kenji Miyake added 2 commits May 20, 2021 01:11
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants