-
Notifications
You must be signed in to change notification settings - Fork 4
Redesign #30
base: main
Are you sure you want to change the base?
Redesign #30
Conversation
📊 Code Metrics Report
|
kenji-miyake
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is under draft, but will leave some comments.
obstacle_stop_planner_refine/include/obstacle_stop_planner/adaptive_cruise_control.hpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/node.hpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/node.hpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/node.hpp
Outdated
Show resolved
Hide resolved
| trajectory.points.push_back(traj_point); | ||
| } | ||
| return trajectory; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should define functions like calcYaw(p1, p2) and createQuaternionFromYaw(yaw).
| using namespace std::chrono_literals; | ||
|
|
||
| // FIXME: Rename function name | ||
| Trajectory convertPointsToTrajectoryWithYaw2( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is Yaw2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a temporary name and will be changed later.
obstacle_stop_planner_refine/test/src/test_obstacle_stop_planner.cpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/test/src/test_obstacle_stop_planner.cpp
Outdated
Show resolved
Hide resolved
* Delete unused functions * Use node_interfaces
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 25.71% 34.91% +9.20%
==========================================
Files 16 15 -1
Lines 1015 885 -130
Branches 569 506 -63
==========================================
+ Hits 261 309 +48
+ Misses 388 157 -231
- Partials 366 419 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Kenji Miyake <[email protected]>
|
@KeisukeShima Replaced unnecessary |
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
What kinds of PR
What is this PR
How to check this PR