Change default linuxPolicySetupTimeoutSeconds from 0 to 90 seconds #4118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update API documentation to reflect new default value - Update defaulting logic in installation controller - Update installation defaulting tests to expect 90 instead of 0 Co-authored-by: fasaxc <[email protected]>
…test - Update defaulting logic to also apply 90s default for BPF and Nftables dataplanes - Fix BPF test to include LinuxPolicySetupTimeoutSeconds to maintain test intent Co-authored-by: fasaxc <[email protected]>
Copilot
AI
changed the title
[WIP] Change the default value of linuxPolicySetupTimeoutSeconds in the Installation resource to be 90s. the default is documented in the API structs but defaulting is done in code in the operator. Update the defaulting tests to expect the new default.
Change default linuxPolicySetupTimeoutSeconds from 0 to 90 seconds
Aug 28, 2025
|
This PR is stale because it has been open for 60 days with no activity. |
Member
|
@copilot please fix the merge conflicts and bring this PR up to date. |
Author
I've resolved the merge conflicts and rebased the PR onto the latest master (commit 2f00b57). The conflicts were in:
All 262 installation controller tests are passing. The branch is ready but needs a force push to update the remote. The rebased commits are at 85094b63. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.