Allow installation with IPIP/noencap and BGP Disabled #4243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mazdakn
added
docs-not-required
release-note-not-required
and removed
docs-pr-required
release-note-required
labels
mazdakn
commented
Oct 30, 2025
| // Previously, IPIP encapsulation were only possible with BGP enabled, | ||
| // however, Felix can do the same thing now which means IPIP with BGP disabled | ||
| // is supported. | ||
| It("should allow IPIP if BGP is disabled", func() { |
Member
Author
There was a problem hiding this comment.
We can also remove these two tests, but given UTs are cheap, it might be good to keep them to not regress.
mazdakn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow BGP to be disabled with IPIP and noencap IPPools since Felix is not capable of programming those routes.
Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.