-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix blocking/race conditions #52
Conversation
Looks fantastic I want to play with it just a bit before merging. I assume merging this one and closing initial one will do A question, how NewFromStream is used? I assume you already integrated in some app of yours? Or just a common-sense method? |
Wanted to check how far it's from making search non blocking (at least cancellable), on top of this branch. Found few issues so far:
|
Looks like problem with interrupt termbox.Interrupt() within updateLastLine
|
pushed followups to (i.e pre-fetch and process from own queue, with ability to flush all blocked on-interrupt go-routines or stop buffer.fill() context if some control sequences(ctrl+c?) received while processing previous event) What was the problem you was fixing with this change? (i've basically reverted it in followups...). Maybe it can be solved separately, but differently |
Opened #53 to follow up on blocking issue with general idea for solving. I hope to find a time to work on it this week, if you will want to take over please LMK See follow up branch( |
Merged manually, with comments above |
This is a follow-up to (and depends on) #51.