Skip to content

Conversation

@kajusnau
Copy link
Collaborator

@kajusnau kajusnau commented Jan 16, 2026

  • Use pulseaudio controls for keyboard shortcuts
  • Fixes an issue where audio keyboard shortcuts might be ignored
  • Reduce amount of givc/pipewire logs in gui and audio vm

Other:

  • Removed eww, wlr-randr and pamixer packages from gui-vm

Description of Changes

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Fixes https://jira.tii.ae/browse/SSRCSP-7847

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Verify bug is fixed
  2. (Optional) verify givc and pipewire error messages are much less frequent in gui and audio vm (QA folks know which ones)

- use pulseaudio controls for keyboard shortcuts
- fixes an issue where audio keyboard shortcuts might be ignored
- reduce amount of givc/pipewire logs in gui and audio vm

Signed-off-by: Kajus Naujokaitis <[email protected]>
@milva-unikie
Copy link

Tested on Lenovo-X1 and Darter Pro (in the lab after the pre-merge run)

  • Volume related keyboard presses (up, down, mute) are not skipped anymore
  • Error messages were reduced by a lot

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76 labels Jan 16, 2026
@brianmcgillion brianmcgillion merged commit 2c21db7 into tiiuae:main Jan 16, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants