DP7417 C++ Implementation of Secure MAVLink proxy on device-side #563
Conversation
|
Please note that px4-firmware is a public repository; I believe that this functionality might be part of "TII" proprietary offering, so maybe move the component in a separate git repository. Now this is publicly visible.. |
| bool get_nonce(uint8_t *nonce, size_t *nonce_len); | ||
| void close() {} | ||
| }; | ||
| static void sodium_crypto_init(void) { |
There was a problem hiding this comment.
Removed sodium_crypto_init, still kept the sodium crypto functions. Overall the purpose of this Crypto wrapper (Crypto.cpp/hpp) is created mainly for testing without HW.
|
I have moved implementation into separate submodule. |
|
btw. use of exit() is a bit fishy in NuttX context; in case of flat build, there are no processes, so it is not clear what all it wants to kill. If the program has been launched from the terminal (nsh shell), exit() will most likely also kill the shell at the same ;) Also as long as you don't intend to use atexit, you could as well call _exit(). Even though exit() is handy, I would recommend not using exit, but just letting threads run to the end / returning error values to the highest level and returning the error value. |
|
The config.yaml is not added to the ROMFS filesystem anywhere for PX4 build; is this intentional? AFAIK, there is no clean way to put in files from within module; it will need to be added separately in ROMFS/ build files. Maybe it is cleaner to make the ports etc. as command line arguments (with some sane defaults hardocoded perhaps), and just skip the yaml file parsing for embedded build ? |
Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
DP-7417-secure-mavlink-udp-proxy-cxx
branch
from
adb7632
to
157f4ff
Compare
jnippula
force-pushed
the
DP-7417-secure-mavlink-udp-proxy-cxx
branch
from
e1f1ed4
to
ebedb60
Compare
jnippula
force-pushed
the
DP-7417-secure-mavlink-udp-proxy-cxx
branch
from
4fb9a06
to
071d32b
Compare
No description provided.