Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platforms/nuttx: Fixes to NuttX CMake rules / dependencies #781

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

pussuw
Copy link

@pussuw pussuw commented Oct 9, 2024

An assortment of cmake script fixes for NuttX kernel mode. The highlights are in the commit messages.

There is no rule to make this target (again) if it is deleted and then
the sources are modified.
- The rule was for the folder boot/ while it should have been for the file
  boot/init
- The rule for bin/ ROMFS depends on boot/init as well, since nsh is moved
  from the bin/ folder and generating the bin/ ROMFS cannot be done prior
  to this step
Do not copy the input directory again, if the target directory already
exists. This confuses Ninja as it tries to remove the boot/ directory, but
it contains sub-directories the build system does not know about (it should
use "rm -rf" but it doesn't know it should)
@pussuw pussuw requested a review from jlaitine October 9, 2024 13:25
@pussuw pussuw changed the title Nuttx cmake fixes platforms/nuttx: Fixes to NuttX CMake rules / dependencies Oct 9, 2024
@pussuw pussuw merged commit 76e28b7 into main Oct 10, 2024
27 checks passed
@pussuw pussuw deleted the nuttx_cmake_fixes branch October 10, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants