Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation: Use fully gazebo NAVSAT data for global position groundtruth #802

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

haitomatic
Copy link

@haitomatic haitomatic commented Nov 1, 2024

This PR simplifies the retrieval of GPS data into PX4 from Gazebo since now all world files do contain GPS coordinates of the location. In details, it:

  • Removes current PX4 parameters for home position GPS coordinates
  • Uses only NAVSAT data from gazebo to initialize home position reference and global position groundtruth

Note: this PR reuses the same simplification from PX4 upstream

@jlaitine
Copy link

jlaitine commented Nov 5, 2024

Is it possible to cherry-pick the changes directly from upstream px4? When we re-base to 1.15.0, is the plan to drop this patch and use upstream code directly?

@haitomatic
Copy link
Author

Yes, i plan to do so. Since now it's quite hard to cherry pick just what we need from 1.15.0 upstream due to commits that also involve other features and changes. But once we update to 1.15.0 we can just use upstream code directly.

@haitomatic haitomatic merged commit 527d024 into main Nov 5, 2024
27 checks passed
@haitomatic haitomatic deleted the HITL_SITL_GPS_from_world_fix branch November 5, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants