txn: refactor set option to detect race risk #1240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: you06 <[email protected]> commit intest package Signed-off-by: you06 <[email protected]> update Signed-off-by: you06 <[email protected]>
you06
force-pushed
the
committer/race-aware
branch
from
26723a7 to
ce69786
Compare
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
…o committer/race-aware
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Contributor
|
@you06 Is this to be closed as the refactored would be done at tidb side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussion in #1235, we need some strategy to avoid data race in committer.
The fields currently used by the committer are lacking protection.