Skip to content

grpc: 1.63.2 -> 1.69.4 #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

grpc: 1.63.2 -> 1.69.4 #1526

wants to merge 7 commits into from
+56 −41

Conversation

iosmanthus
Copy link
Member

grpc.NewSharedBufferPool is enabled by default in grpc 1.69.0, we could remove the GrpcSharedBufferPool option of client-go.

Fore more information, see: https://pkg.go.dev/google.golang.org/grpc/experimental#WithBufferPool

@iosmanthus
grpc: 1.63.2 -> 1.69.0
421daab 
Signed-off-by: iosmanthus <[email protected]>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2024
@iosmanthus iosmanthus changed the title grpc: 1.63.2 -> 1.69.0 grpc: 1.63.2 -> 1.69.4 Jan 24, 2025
@hawkingrei
Copy link
Member

ref pingcap/tidb#50627

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 3, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-03 18:43:07.351986547 +0000 UTC m=+294300.480906288: ☑️ agreed by disksing.

@ti-chi-bot ti-chi-bot bot added the approved label Mar 3, 2025
@heavycrystal
Copy link

does this PR need work or can it be merged?
google.golang.org/grpc is now at v1.72.0

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 4, 2025

@benmeadowcroft: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmeadowcroft, disksing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmeadowcroft benmeadowcroft benmeadowcroft approved these changes

@disksing disksing disksing approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iosmanthus @hawkingrei @heavycrystal @benmeadowcroft @disksing