-
Notifications
You must be signed in to change notification settings - Fork 250
Delete txn scope code #1587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Delete txn scope code #1587
Conversation
Signed-off-by: ekexium <[email protected]>
72d2742 to
cf6688e
Compare
Signed-off-by: ekexium <[email protected]>
cf6688e to
13eacc3
Compare
Signed-off-by: ekexium <[email protected]>
Signed-off-by: ekexium <[email protected]>
ebcff5c to
53fe1c7
Compare
Signed-off-by: ekexium <[email protected]>
53fe1c7 to
4ab4b5f
Compare
|
@JmPotato PTAL |
config/config.go
Outdated
| TxnScope string | ||
| EnableAsyncCommit bool | ||
| Enable1PC bool | ||
| // FIXME: rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide more explanation about this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
| // Option represents available options for the oracle.Oracle. | ||
| // TODO: remove this struct | ||
| type Option struct { | ||
| TxnScope string | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just remove it in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To minimize the change.. It has hundreds of usages. I prefer keeping this PR (relatively) small
zyguan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, any plan to deprecate (or rename) oracle.GlobalTxnScope?
Signed-off-by: ekexium <[email protected]>
Signed-off-by: ekexium <[email protected]>
Yes, I think it's the last step. After we deprecated txn-scope related code, we can rename those left to names like |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
7a0b904 to
2b44a8a
Compare
Signed-off-by: ekexium <[email protected]>
2b44a8a to
1cee44c
Compare
|
You can ignore the leak goroutine to fix the test. client-go/integration_tests/main_test.go Lines 27 to 31 in 469a7ad
opts := []goleak.Option{
goleak.IgnoreTopFunction("github.com/pingcap/goleveldb/leveldb.(*DB).mpoolDrain"),
goleak.IgnoreTopFunction("github.com/tikv/client-go/v2/txnkv/transaction.keepAlive"), // TODO: fix ttlManager goroutine leak
goleak.IgnoreTopFunction("github.com/tikv/client-go/v2/config/retry.(*Config).createBackoffFn.newBackoffFn.func2"),
+ goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start"),
} |
Signed-off-by: ekexium <[email protected]>
Part of pingcap/tidb#58838
Some changes that I'm not sure about:
TestMinSafeTsFromMixed1andTestMinSafeTsFromMixed2updateGlobalTxnScopeTSFromPD